[M] Change in osmo-bts[master]: Add GSMTAP encapsulation of RLP frames in CSD NT mode - gerrit-log

26 Nov 2023

Attention is currently required from: fixeria.

laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/35124?usp=email )

Change subject: Add GSMTAP encapsulation of RLP frames in CSD NT mode
......................................................................

Patch Set 2:

(3 comments)

This change is ready for review.

Patchset:

PS1: 
...
  this needs to be vty-configurable and should likely
contain a [default] setting of suppressing any N […] Done

File src/common/l1sap.c:

https://gerrit.osmocom.org/c/osmo-bts/+/35124/comment/05a0cb5b_9de0bc77 
PS1, Line 1855: GSMTAP_CHANNEL_TCH_H : GSMTAP_CHANNEL_TCH_F
...
  I was thinking about the same, but then wasn't
really sure if we should really add those. […] Done

https://gerrit.osmocom.org/c/osmo-bts/+/35124/comment/cbff05d0_7e89d3ef 
PS1, Line 1868: lchan->csd_mode == LCHAN_CSD_M_NT
...
  I think we should buffer and re-assemble those two
blocks in osmo-bts. […] Done

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35124?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I6a258458822bcb3fe7290a9b9b3d104beecda219
Gerrit-Change-Number: 35124
Gerrit-PatchSet: 2
Gerrit-Owner: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Comment-Date: Sun, 26 Nov 2023 17:30:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge &lt;laforge(a)osmocom.org&gt;
Comment-In-Reply-To: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-MessageType: comment