Attention is currently required from: neels, pespin, fixeria.

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31578 )

Change subject: pcu_sock: use struct to transfer IMMEDIATE ASSIGNMENT for PCH ......................................................................

Patch Set 10:

(3 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-bsc/+/31578/comment/20c11cd3_bb8716ad PS8, Line 10: "direct TLLI" method, the TLLI (and the paging group) is premended to

probably "prepended"

Done

File src/osmo-bsc/pcu_sock.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/31578/comment/c3c0c5a4_605ce3e7 PS8, Line 581: msg = msgb_alloc(sizeof(pch_dt->data), "pcu_pch");

this is just moving code from a previous patch, but in fact this msgb is leaked! It should have been […]

Thanks. I didn't see this while editing the code. Thats a really nasty bug.

https://gerrit.osmocom.org/c/osmo-bsc/+/31578/comment/eb263bad_699a1b8d PS8, Line 595: msg->len, msg->data

... […]

Done