Jenkins Builder has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42357?usp=email )

Change subject: proto_trxd: add helpers to prepare burst indication packets ......................................................................

Patch Set 1:

(8 comments)

File Transceiver52M/proto_trxd.h:

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42357/comment/2d4c3133_daa54266?usp=... : PS1, Line 39: ssize_t trxd_prepare_burst_ind_v0(const struct trx_ul_burst_ind *bi, char* buf, size_t maxLen); "foo* bar" should be "foo *bar"

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42357/comment/7168f61b_3862689a?usp=... : PS1, Line 42: ssize_t trxd_prepare_burst_ind_v1(const struct trx_ul_burst_ind *bi, char* buffer, size_t maxLen); "foo* bar" should be "foo *bar"

File Transceiver52M/proto_trxd.c:

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42357/comment/5cc79935_e9484e3f?usp=... : PS1, Line 68: ssize_t trxd_prepare_burst_ind_v0(const struct trx_ul_burst_ind *bi, char* buf, size_t maxLen) "foo* bar" should be "foo *bar"

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42357/comment/d1a18647_f1623f81?usp=... : PS1, Line 92: bool trxd_send_burst_ind_v0(size_t chan, int fd, const struct trx_ul_burst_ind *bi) { open brace '{' following function definitions go on the next line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42357/comment/b208edf2_adb9eb4f?usp=... : PS1, Line 114: ssize_t trxd_prepare_burst_ind_v1(const struct trx_ul_burst_ind *bi, char* buffer, size_t maxLen) "foo* bar" should be "foo *bar"

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42357/comment/37f76ac5_245adf76?usp=... : PS1, Line 123: struct trxd_hdr_v1* pkt = (struct trxd_hdr_v1*)buffer; "(foo*)" should be "(foo *)"

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42357/comment/f4a3d7cc_c332189e?usp=... : PS1, Line 123: struct trxd_hdr_v1* pkt = (struct trxd_hdr_v1*)buffer; "foo* bar" should be "foo *bar"

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42357/comment/9b1118a1_ed8c37c7?usp=... : PS1, Line 134: bool trxd_send_burst_ind_v1(size_t chan, int fd, const struct trx_ul_burst_ind *bi) { open brace '{' following function definitions go on the next line