Attention is currently required from: neels, msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29087 ) Change subject: SIGTRAN: add function to check connection existence ...................................................................... Patch Set 12: (2 comments) File examples/sccp_test_vty.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29087/comment/c3633442_e7d22e25 PS8, Line 44: int conn_id = atoi(argv[0]), ret; I agree with Neels that doing "int a = ..., rc;" hides definition of rc. I find it harder to read than if it was on a separate line. If not a separate line, "int rc, a = ...;" is an acceptable solution too. Regarding ret vs rc - I don't care. File src/sccp_scoc.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29087/comment/501d0b7f_b6c20a69 PS12, Line 459: osmo_sccp_conn_id_exists So this function basically converts the result of conn_find_by_id() to boolean. Not sure if it's really beneficial to add a new symbol, you could simply expose conn_find_by_id() and call it directly when you need to check connection existence. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29087 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Iffedf55b4c292ee6b2f97bcdeef6dc13c050ce01 Gerrit-Change-Number: 29087 Gerrit-PatchSet: 12 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Sun, 21 Aug 2022 16:42:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment