[S] Change in osmo-ttcn3-hacks[master]: library/gsup: fix wrong IE order in f_gen_tr_ss_ies - gerrit-log

31 Oct 2024


      Attention is currently required from: fixeria.
laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38586?usp=email )
Change subject: library/gsup: fix wrong IE order in f_gen_tr_ss_ies
......................................................................
Patch Set 2:
(1 comment)
File library/GSUP_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38586/comment/eb3b7994_bf9bf... :
PS2, Line 1412: 	ies[idx] := *;
well, the comment says something about a specific IE type (OSMO_GSUP_MESSAGE_CLASS_IE) while the actual code seems to accept any IE type.  That's definitely not the same.
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38586?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5aafbc885d3b78fd37f84feebf5dab1255d51eb1
Gerrit-Change-Number: 38586
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge laforge@osmocom.org
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Thu, 31 Oct 2024 01:14:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No