[L] Change in osmo-pcap[master]: server: Support storing of pcapng format - gerrit-log

13 Jan 2025


      Attention is currently required from: daniel, pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39287?usp=email )
Change subject: server: Support storing of pcapng format
......................................................................
Patch Set 5: Code-Review+1
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-pcap/+/39287/comment/ea3fb3a7_280a450e?usp... :
PS5, Line 13: This requires, during LINK_HDR when file header is received, discering
discering? do you mean distinguishing?
File src/osmo_server_network.c:
https://gerrit.osmocom.org/c/osmo-pcap/+/39287/comment/f7fa1dde_c2471f3b?usp... :
PS5, Line 352: BLOCK_TYPE_SHB
why LOGL_DEBUG here vs LOGL_ERROR above for the other implausible things?
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39287?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-Change-Id: I275d28ab418a1514fa9c5c7c20f3d831cc6af8bb
Gerrit-Change-Number: 39287
Gerrit-PatchSet: 5
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel dwillmann@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Attention: daniel dwillmann@sysmocom.de
Gerrit-Comment-Date: Mon, 13 Jan 2025 19:14:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes