Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39144?usp=email ) Change subject: library/s1ap: add E-RAB MODIFY IND/CNF templates ...................................................................... Patch Set 1: (4 comments) File library/s1ap/S1AP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39144/comment/1232f1db_aa4e… : PS1, Line 1962: template (omit) E_RABNotToBeModifiedListBearerModInd rab_no_modify_items) It's already `omit` in the template using this helper, I see no point assigning default values here. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39144/comment/e5a01bb7_432e… : PS1, Line 1999: template E_RABNotToBeModifiedListBearerModInd rab_no_modify_items) Likewise, see the template using this helper. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39144/comment/06175ee6_d699… : PS1, Line 2147: template (omit) E_RABModifyListBearerModConf rab_modified_items, Likewise, it's a private helper function. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39144/comment/4051abfe_dcd6… : PS1, Line 2197: template E_RABModifyListBearerModConf rab_modified_items, Same here. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39144?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2dd3d420ebfaf37fefa1d33a40176ec57fee5619 Gerrit-Change-Number: 39144 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 15 Dec 2024 07:29:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>