Attention is currently required from: pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39144?usp=email )
Change subject: library/s1ap: add E-RAB MODIFY IND/CNF templates ......................................................................
Patch Set 1:
(4 comments)
File library/s1ap/S1AP_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39144/comment/1232f1db_aa4e2... : PS1, Line 1962: template (omit) E_RABNotToBeModifiedListBearerModInd rab_no_modify_items)
:= omit
It's already `omit` in the template using this helper, I see no point assigning default values here.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39144/comment/e5a01bb7_432ed... : PS1, Line 1999: template E_RABNotToBeModifiedListBearerModInd rab_no_modify_items)
:= *
Likewise, see the template using this helper.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39144/comment/06175ee6_d6996... : PS1, Line 2147: template (omit) E_RABModifyListBearerModConf rab_modified_items,
:= omit x3
Likewise, it's a private helper function.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39144/comment/4051abfe_dcd66... : PS1, Line 2197: template E_RABModifyListBearerModConf rab_modified_items,
:= * x3
Same here.