fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/31894 )

Change subject: mslookup: Call osmo_fd_unregister() before closing and changing bfd->fd ......................................................................

mslookup: Call osmo_fd_unregister() before closing and changing bfd->fd

Change-Id: I26bba0dd092ad5fd6b4959b173fae93b542a93f1 --- M src/mslookup/osmo-mslookup-client.c 1 file changed, 11 insertions(+), 2 deletions(-)

Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved

diff --git a/src/mslookup/osmo-mslookup-client.c b/src/mslookup/osmo-mslookup-client.c index d2a629f..37f1256 100644 --- a/src/mslookup/osmo-mslookup-client.c +++ b/src/mslookup/osmo-mslookup-client.c @@ -419,9 +419,9 @@ { struct osmo_fd *ofd = &c->ofd;

+ osmo_fd_unregister(ofd); close(ofd->fd); ofd->fd = -1; - osmo_fd_unregister(ofd);

llist_del(&c->entry); talloc_free(c); @@ -561,9 +561,9 @@ llist_for_each_entry_safe(c, n, &globals.socket_clients, entry) socket_client_close(c); if (osmo_fd_is_registered(&globals.socket_ofd)) { + osmo_fd_unregister(&globals.socket_ofd); close(globals.socket_ofd.fd); globals.socket_ofd.fd = -1; - osmo_fd_unregister(&globals.socket_ofd); } }