Attention is currently required from: pespin.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34900?usp=email )
Change subject: add fmtp string to ptmap: allow all possible fmtp ......................................................................
Patch Set 4:
(2 comments)
File include/osmocom/mgcp_client/mgcp_client.h:
https://gerrit.osmocom.org/c/osmo-mgw/+/34900/comment/d9843f6b_d3a929cb PS4, Line 165: * Not all pointers contained in the mgcp_response */
what do you mean with this?
erm ... no i didn't write this. i started out with dexter's patch, maybe that's where it came from...?
what is it trying to say, i guess mgcp_response allocation is not entirely self-contained.
Looking, though, it actually does self-contain all its members, except for the 'sdp' pointer that includes the originally parsed SDP string. So seems to have become unrelated to this patch.
File tests/mgcp/mgcp_test.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/34900/comment/3f2647a6_b3917892 PS4, Line 848: fflush(stderr);
is this really needed? […]
another such something i didn't see, thx
-
neels