Attention is currently required from: laforge, lynxis lazus, pespin.
fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37901?usp=email )
Change subject: s2b: when socket opening fails, stop the S2b module
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
File src/epdg_gtpc_s2b.erl:
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37901/comment/6a49d79a_2d793... :
PS3, Line 150: io_lib:format
I agree with fixeria
Done
--
To view, visit
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37901?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I49a6a1ec0c938aa70444c19c0b7b644f2e42f1fd
Gerrit-Change-Number: 37901
Gerrit-PatchSet: 5
Gerrit-Owner: lynxis lazus
lynxis@fe80.eu
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Attention: lynxis lazus
lynxis@fe80.eu
Gerrit-Comment-Date: Wed, 10 Dec 2025 14:24:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge
laforge@osmocom.org
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de
Comment-In-Reply-To: lynxis lazus
lynxis@fe80.eu