Attention is currently required from: fixeria, laforge.
osmith has posted comments on this change by fixeria. (
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39415?usp=email )
Change subject: Add GSMTAP logging handler
......................................................................
Patch Set 9: Code-Review+1
(1 comment)
File config/sys.config:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39415/comment/26a3bc70_d756…
:
PS9, Line 39: app_name => "OsmoS1GW"}}},
AFAIK we don't enable gsmtap logging by default in other Osmocom default configs. So
maybe comment it out here too, so users can easily enable it on demand?
--
To view, visit
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39415?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: Iea884e2ca146b852c64bd9f135d8c71f4c925f09
Gerrit-Change-Number: 39415
Gerrit-PatchSet: 9
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 28 Jul 2025 12:51:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes