Attention is currently required from: fixeria, matanp.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32565 )

Change subject: ctrl: Add getting neighbor list ......................................................................

Patch Set 3:

(1 comment)

File src/osmo-bsc/bts_ctrl.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/32565/comment/5474134d_d2f1b046 PS3, Line 531: cmd->reply = talloc_asprintf_append(cmd->reply, i == 0 ? "%u" : " %u", i); there's several things I'm not liking here: 1- I'd better go for a non-whitespace separator. I think we use comma "," as a separator in other lists 2- AFAIU you are allocating a new string on each iteration, ie. for each neighbor. I'd fancy much more a better approach, such as allocating buffers incrementing size *2 when it becomes full. At least, free the previous string before allocating new one so you don't end up with 200 allocated strings.