Attention is currently required from: fixeria, matanp.

View Change

1 comment:

• File src/osmo-bsc/bts_ctrl.c:

  • Patch Set #3, Line 531: cmd->reply = talloc_asprintf_append(cmd->reply, i == 0 ? "%u" : " %u", i);

    there's several things I'm not liking here:
    1- I'd better go for a non-whitespace separator. I think we use comma "," as a separator in other lists
    2- AFAIU you are allocating a new string on each iteration, ie. for each neighbor. I'd fancy much more a better approach, such as allocating buffers incrementing size *2 when it becomes full. At least, free the previous string before allocating new one so you don't end up with 200 allocated strings.

To view, visit change 32565. To unsubscribe, or for help writing mail filters, visit settings.