Attention is currently required from: osmith, msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30444 )
Change subject: ctrl: add optional port to bind command ......................................................................
Patch Set 5:
(1 comment)
File src/ctrl/control_vty.c:
https://gerrit.osmocom.org/c/libosmocore/+/30444/comment/03fece6d_2300c075 PS5, Line 34: "bind A.B.C.D [<0-65535>]",
That's exactly how vty_get_bind_port() works though. […]
in the VTY case, IMHO the idea was that the "usual" caller of vty_bind_get_port() is inside libosmovty itself: The function telnet_init_default(). Unfortunately it seems that (almost) all apps still call telnet_init_dynif(). That's a separate bug, will report it: https://osmocom.org/issues/5809
In order to avoid repeating this for thye CTRL interface, you'd also have to create a @ctrl_interface_setup_default()@ function, mark the other ones as deprecated and port all applications over from @ctrl_interface_setup_dynip()@ to that new function.
-
laforge