Change in osmo-sgsn[master]: Replace gprs_str_to_apn() with libosmocore API osmo_apn_from_str() - gerrit-log

4 Jan 2023


      Attention is currently required from: pespin.
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/30861 )
Change subject: Replace gprs_str_to_apn() with libosmocore API osmo_apn_from_str()
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File tests/sgsn/sgsn_test.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/30861/comment/53cbd5c8_47a9edf8 
PS1, Line 40: #include <osmocom/sgsn/gprs_gmm_fsm.h>
This looks like an incomplete alphabetical sort (vty should go to the bottom, gsupclient in between sgsn, gprs_gmm_fsm out of place).
The only functional change is the addition of apn.h?
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/30861
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ibef55a648f2d58f4fdd24fa553efde530982af2d
Gerrit-Change-Number: 30861
Gerrit-PatchSet: 1
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel dwillmann@sysmocom.de
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Wed, 04 Jan 2023 17:48:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment