Attention is currently required from: pespin.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-upf/+/27221
)
Change subject: libosmo-pfcp: add pfcp_proto.h pfcp_strs.h
......................................................................
Patch Set 6:
(2 comments)
Patchset:
PS1:
It would be interesting to know how did you generate
all this. […]
that is interesting. i wonder how they get consistent alignment, not
from a pdf file i guess?
Patchset:
PS3:
You did all this by hand manually?
goodness
no!!
i copied from the specs and semi-manually aligned it to a consistent tab separated list
(see contrib/pfcp_iei.txt) and then did vim fu like s/.../.../ and CTRL+v,U to shape it to
this.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-upf/+/27221
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I568b821e89007ed52eeefcdbcb6edd8052a8b5be
Gerrit-Change-Number: 27221
Gerrit-PatchSet: 6
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 21 Mar 2022 17:09:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment