Attention is currently required from: laforge.
neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/41779?usp=email )
Change subject: personalization: refactor SmspTpScAddr
......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
(i hope i'm allowed to just resolve this because of the abstract method aspect)
File pySim/esim/saip/personalization.py:
https://gerrit.osmocom.org/c/pysim/+/41779/comment/8337a2e2_81b72db2?usp=ema... :
PS1, Line 362: val must be a tuple (international[bool], digits[str])
This is a specific implementation of an abstract class method. […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/41779?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I2600369e195e9f5aed7f4e6ff99ae273ed3ab3bf
Gerrit-Change-Number: 41779
Gerrit-PatchSet: 1
Gerrit-Owner: neels
nhofmeyr@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Comment-Date: Sun, 11 Jan 2026 03:40:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels
nhofmeyr@sysmocom.de
Comment-In-Reply-To: laforge
laforge@osmocom.org