Attention is currently required from: fixeria, osmith.
pespin has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/libosmo-sigtran/+/38347?usp=email )
Change subject: tests/vty: Add vty-transcript-test for osmo-stp
......................................................................
Patch Set 3:
(1 comment)
File tests/vty/osmo_stp_test.vty:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/38347/comment/2be5698f_6d8a7…
:
PS3, Line 104: description .TEXT
I just copied the file from ss7_asp_test.vty to have
similar testing for both asp and sg. […]
Wait, this is actually a specific param
added in the lib code, so I think yes it should appear here:
src/osmo_ss7_vty.c:
install_lib_element(L_CS7_NODE, &cfg_description_cmd);
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/38347?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: If2f069b9d724038c326f5c35848faa1e9c216fd5
Gerrit-Change-Number: 38347
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 07 Oct 2024 16:06:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>