Attention is currently required from: pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42352?usp=email )
Change subject: mme_registry: add backwards compat for old sctp_client config ......................................................................
Patch Set 1:
(1 comment)
File src/osmo_s1gw_sup.erl:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42352/comment/0a79e835_bfe68... : PS1, Line 75: osmo_s1gw:set_env(sctp_client, ClientCfg),
shouldn't this be set only if the mme_pool is missing?
It does not make a big difference. Having a normalized `sctp_client` in the environment does not hurt and may later be used e.g. by the REST interface to print the current configuration.