pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36640?usp=email )
Change subject: SIP_Emulation: Remove duplicated map() ......................................................................
SIP_Emulation: Remove duplicated map()
The map() is already done before the component is started, f_init_sip(). It's better doing it there because then it's up to the creator of the SIP_Emulation component to establish the name of the system port, hence allowing multiple instances which can be configured differently (eg. different bind ip+port).
Change-Id: I5632c94d03a9dce0d04d94766ce72e6700b6116b --- M library/SIP_Emulation.ttcn 1 file changed, 15 insertions(+), 5 deletions(-)
Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved
diff --git a/library/SIP_Emulation.ttcn b/library/SIP_Emulation.ttcn index 559b575..1b357b7 100644 --- a/library/SIP_Emulation.ttcn +++ b/library/SIP_Emulation.ttcn @@ -62,10 +62,6 @@ port SIPEM_PROC_PT CLIENT_PROC; };
-private function f_sip_init() runs on SIP_Emulation_CT { - map(self:SIP, system:SIP); -} - template RequestLine tr_ReqLine(template Method method) := { method := method, requestUri := ?, @@ -245,7 +241,6 @@ function main(SipOps ops, charstring id) runs on SIP_Emulation_CT {
- f_sip_init(); f_expect_table_init(); f_call_table_init();