Change in osmo-e1d[master]: usb: Add support for new GPSDO status field "Accumulated error" - gerrit-log

6 Oct 2022

Attention is currently required from: tnt.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-e1d/+/29618 )

Change subject: usb: Add support for new GPSDO status field "Accumulated error"
......................................................................

Patch Set 6: Code-Review+2

(2 comments)

File src/ice1usb_proto.h:

https://gerrit.osmocom.org/c/osmo-e1d/+/29618/comment/20e17f2e_78fe84c8 
PS3, Line 68: 	int16_t  err_acc;		/*!< Accumulated error */
...
  I added a reference to the next (yet to be
tagged/release) version (since it'll be the first to have […] Done

File src/usb.c:

https://gerrit.osmocom.org/c/osmo-e1d/+/29618/comment/176bb43f_f1484aa8 
PS3, Line 715: 			"Some values will be zeroed\n",
...
  Yup notice is probably a bit much. Switched to DEBUG.
[…] Done

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/29618
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: I4222bf22267f8343abf1e97546111ceb1c299846
Gerrit-Change-Number: 29618
Gerrit-PatchSet: 6
Gerrit-Owner: tnt &lt;tnt(a)246tNt.com&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Attention: tnt &lt;tnt(a)246tNt.com&gt;
Gerrit-Comment-Date: Thu, 06 Oct 2022 10:35:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge &lt;laforge(a)osmocom.org&gt;
Comment-In-Reply-To: tnt &lt;tnt(a)246tNt.com&gt;
Gerrit-MessageType: comment