Attention is currently required from: fixeria, osmith, pespin.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/mncc-python/+/36318?usp=email )
Change subject: Initial port from python2 to python3
......................................................................
Patch Set 4:
(2 comments)
File mncc_test.py:
https://gerrit.osmocom.org/c/mncc-python/+/36318/comment/9de405a7_b5088d31
PS3, Line 72: return
This is wrong, you need four more spaces. Otherwise
the code below in unreachable.
Done
File rtpsource/Makefile:
https://gerrit.osmocom.org/c/mncc-python/+/36318/comment/98b7943b_05fa3d81
PS3, Line 2: lasan
this looks unrelated to the py3 migration?
Done
--
To view, visit
https://gerrit.osmocom.org/c/mncc-python/+/36318?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: mncc-python
Gerrit-Branch: master
Gerrit-Change-Id: Ie6ecd37353b35a6ac13c6578585c714c9ab46e06
Gerrit-Change-Number: 36318
Gerrit-PatchSet: 4
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 17 Mar 2024 17:49:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment