Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmocore/+/39276?usp=email ) Change subject: osmo_iofd_register: fix the case of changing fd ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: I think the proper fix is simply to add a line after the last "if" code path check: "iofd->fd = fd;" File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/39276/comment/692a9e53_daf00168?… : PS1, Line 756: else if (iofd->fd < 0) I think you need to leave this as is. This code block basically makes sure that iofd->fd == fd if any of them was not set (-1). -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39276?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If8b8486ad7934afa203dfe1e996c9217373a017b Gerrit-Change-Number: 39276 Gerrit-PatchSet: 1 Gerrit-Owner: falconia &lt;falcon(a)freecalypso.org&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: falconia &lt;falcon(a)freecalypso.org&gt; Gerrit-Comment-Date: Thu, 09 Jan 2025 19:50:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No