Attention is currently required from: fixeria, laforge, pespin.

jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34495?usp=email )

Change subject: ASCI: Add VTY commands to control voice group/broadcast calls ......................................................................

Patch Set 16:

(2 comments)

File src/host/layer23/src/mobile/vty_interface.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/34495/comment/c75d73d4_ca937e73 PS16, Line 379: ASCI_STR

You're missing `SHOW_STR` here, it should be: […]

It is already added in the #define above. I renamed it to SHOW_ASCI_STR, to make this clearer.

https://gerrit.osmocom.org/c/osmocom-bb/+/34495/comment/928e0c2b_e0cf94a9 PS16, Line 700: These commands perform VGCS on given MS without entering the VGCS node

So then is there really a need for having a dedicated VTY node for just one command, which is also a […]

You can switch between talk and listen without having a full command. Just enter "talk" or "listen" or other sub-commands.