Attention is currently required from: fixeria, laforge, pespin.
jolly has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/34495?usp=email )
Change subject: ASCI: Add VTY commands to control voice group/broadcast calls
......................................................................
Patch Set 16:
(2 comments)
File src/host/layer23/src/mobile/vty_interface.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/34495/comment/c75d73d4_ca937e73
PS16, Line 379: ASCI_STR
You're missing `SHOW_STR` here, it should be: […]
It is already added in the #define above. I renamed it to SHOW_ASCI_STR, to make
this clearer.
https://gerrit.osmocom.org/c/osmocom-bb/+/34495/comment/928e0c2b_e0cf94a9
PS16, Line 700: These commands perform VGCS on given MS without entering the VGCS node
So then is there really a need for having a dedicated
VTY node for just one command, which is also a […]
You can switch between talk and
listen without having a full command. Just enter "talk" or "listen" or
other sub-commands.
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/34495?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Id32253b4e10b8df48e819d8a92bbcda332dd11e6
Gerrit-Change-Number: 34495
Gerrit-PatchSet: 16
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 04 Oct 2023 10:47:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment