pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/41575?usp=email )

Change subject: gprs_gmm: fix endianess of GSM48_IE_GMM_PDP_CTX_STATUS ......................................................................

gprs_gmm: fix endianess of GSM48_IE_GMM_PDP_CTX_STATUS

The pdp_status is actually encoded as little endian, but there is no tlvp_val16le yet.

Change-Id: Ib9bee2f8d0b1f89986d15cf3ce6404ad76378c8c (cherry picked from commit b79797d0568ffd757540f6307d538135bdfa01b8) --- M src/sgsn/gprs_gmm.c 1 file changed, 2 insertions(+), 1 deletion(-)

Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved osmith: Looks good to me, but someone else must approve

diff --git a/src/sgsn/gprs_gmm.c b/src/sgsn/gprs_gmm.c index 7a4ea20..d70ceec 100644 --- a/src/sgsn/gprs_gmm.c +++ b/src/sgsn/gprs_gmm.c @@ -2009,7 +2009,8 @@ /* Look at PDP Context Status IE and see if MS's view of * activated/deactivated NSAPIs agrees with our view */ if (TLVP_PRESENT(&tp, GSM48_IE_GMM_PDP_CTX_STATUS)) { - uint16_t pdp_status = tlvp_val16be(&tp, GSM48_IE_GMM_PDP_CTX_STATUS); + /* TODO: Use tlvp_val16le when available */ + uint16_t pdp_status = osmo_load16le(TLVP_VAL(&tp, GSM48_IE_GMM_PDP_CTX_STATUS));

process_ms_ctx_status(ctx, pdp_status);