Attention is currently required from: jolly. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34361?usp=email ) Change subject: ASCI: Add BCC call state definitions ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File include/osmocom/gsm/protocol/gsm_44_068.h: https://gerrit.osmocom.org/c/libosmocore/+/34361/comment/73b671e2_d084d12a PS1, Line 69: OSMO_GSM44068_CSTATE_U2sl_U2 So, you're changing public API here. The usual approach is to add defines with old names for backwards compatibility. But I see that it's relatively new API (2023-04-20), and most likely there are no API users, so it should be fine. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34361?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2180b43b940542565188f52c554c960858fe2a95 Gerrit-Change-Number: 34361 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 11 Sep 2023 17:22:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment