Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36299?usp=email ) Change subject: doc: various osmux API documentation updates ...................................................................... Patch Set 1: (2 comments) File src/osmux.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15133): https://gerrit.osmocom.org/c/libosmo-netif/+/36299/comment/0e4f2b3e_ec96c2d6 PS1, Line 30: #define SNPRINTF_BUFFER_SIZE(ret, remain, offset) \ Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15133): https://gerrit.osmocom.org/c/libosmo-netif/+/36299/comment/356daf0a_afa94cb1 PS1, Line 30: #define SNPRINTF_BUFFER_SIZE(ret, remain, offset) \ macros should not use a trailing semicolon -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36299?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I5af0133322ddd5345a13380f1c007474c0bea117 Gerrit-Change-Number: 36299 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Fri, 15 Mar 2024 13:08:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment