Jenkins Builder has posted comments on this change by keith. ( https://gerrit.osmocom.org/c/osmo-bsc/+/40917?usp=email )

Change subject: * Add functions to set LAC/CI on a BTS and update hashtables. * Use these function from both the vty and the control interface. ......................................................................

Patch Set 1:

(8 comments)

File src/osmo-bsc/bts.c:

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/2a047d6f_fd94ae51?usp=... : PS1, Line 761: int gsm_bts_set_lac(struct gsm_bts *bts, int lac) { open brace '{' following function definitions go on the next line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/f991221e_191eaf7a?usp=... : PS1, Line 772: int gsm_bts_set_ci(struct gsm_bts *bts, int ci) { open brace '{' following function definitions go on the next line

File src/osmo-bsc/bts_ctrl.c:

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/b56b4ce5_4b24165d?usp=... : PS1, Line 247: static int get_bts_lac(struct ctrl_cmd *cmd, void *data) { open brace '{' following function definitions go on the next line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/f8b8d0e1_b5534a54?usp=... : PS1, Line 257: static int set_bts_lac(struct ctrl_cmd *cmd, void *data) { open brace '{' following function definitions go on the next line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/927f1be0_3c5ef528?usp=... : PS1, Line 266: static int verify_bts_lac(struct ctrl_cmd *cmd, const char *value, void *data) { open brace '{' following function definitions go on the next line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/5e1af576_9ed217d0?usp=... : PS1, Line 280: static int get_bts_ci(struct ctrl_cmd *cmd, void *data) { open brace '{' following function definitions go on the next line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/a5dce18b_eeffb69e?usp=... : PS1, Line 290: static int set_bts_ci(struct ctrl_cmd *cmd, void *data) { open brace '{' following function definitions go on the next line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/c093b738_d568d0f8?usp=... : PS1, Line 299: static int verify_bts_ci(struct ctrl_cmd *cmd, const char *value, void *data) { open brace '{' following function definitions go on the next line