Attention is currently required from: laforge, pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32758 ) Change subject: osmo_io: Improve handling and documentation of segmentation_cb ...................................................................... Patch Set 4: (2 comments) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/32758/comment/b0d74305_7a2f55de PS3, Line 9: int Done File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/32758/comment/4e9186b7_e6fc402c PS3, Line 249: } else if (pending_len < 0) { Then I'd have to use -pending_len down in the memcpy which I like much less. You have three cases which I tried to explain in the comments: * You receive exactly one complete message, simply return the whole msgb * You receive an incomplete message, save the whole msgb for later * You receive more than one message, return the first message and save the rest (pending_len) for later -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32758 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6a0eebb8d4490f09a3cc6eb97d4ff47b4a8fd377 Gerrit-Change-Number: 32758 Gerrit-PatchSet: 4 Gerrit-Owner: daniel &lt;dwillmann(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-CC: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Comment-Date: Fri, 19 May 2023 09:17:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge &lt;laforge(a)osmocom.org&gt; Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt; Comment-In-Reply-To: daniel &lt;dwillmann(a)sysmocom.de&gt; Gerrit-MessageType: comment