Attention is currently required from: laforge, pespin.
View Change
2 comments:
Commit Message:
File src/core/osmo_io.c:
Patch Set #3, Line 249: } else if (pending_len < 0) {
ok, maybe the ting here is that you should declare: […]
Then I'd have to use -pending_len down in the memcpy which I like much less.
You have three cases which I tried to explain in the comments:
- You receive exactly one complete message, simply return the whole msgb
- You receive an incomplete message, save the whole msgb for later
- You receive more than one message, return the first message and save the rest (pending_len) for later
To view, visit change 32758. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I6a0eebb8d4490f09a3cc6eb97d4ff47b4a8fd377
Gerrit-Change-Number: 32758
Gerrit-PatchSet: 4
Gerrit-Owner: daniel <dwillmann@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-CC: pespin <pespin@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Comment-Date: Fri, 19 May 2023 09:17:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge@osmocom.org>
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Comment-In-Reply-To: daniel <dwillmann@sysmocom.de>
Gerrit-MessageType: comment