Attention is currently required from: laforge, pespin.
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32758 )
Change subject: osmo_io: Improve handling and documentation of segmentation_cb ......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/libosmocore/+/32758/comment/b0d74305_7a2f55de PS3, Line 9: int
in
Done
File src/core/osmo_io.c:
https://gerrit.osmocom.org/c/libosmocore/+/32758/comment/4e9186b7_e6fc402c PS3, Line 249: } else if (pending_len < 0) {
ok, maybe the ting here is that you should declare: […]
Then I'd have to use -pending_len down in the memcpy which I like much less.
You have three cases which I tried to explain in the comments:
* You receive exactly one complete message, simply return the whole msgb * You receive an incomplete message, save the whole msgb for later * You receive more than one message, return the first message and save the rest (pending_len) for later