Attention is currently required from: laforge, pespin, fixeria.
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31417 )
Change subject: l1sap: Accept RFC5993 and TS 101.318 HR GSM payload ......................................................................
Patch Set 2:
(3 comments)
File src/common/l1sap.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3941): https://gerrit.osmocom.org/c/osmo-bts/+/31417/comment/778ba377_993bb992 PS2, Line 1267: } else else is not generally useful after a break or return
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3941): https://gerrit.osmocom.org/c/osmo-bts/+/31417/comment/eac2b05e_2c06847f PS2, Line 1267: } else suspect code indent for conditional statements (16, 20)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3941): https://gerrit.osmocom.org/c/osmo-bts/+/31417/comment/7b6e5f80_840f97e3 PS2, Line 1268: if (OSMO_UNLIKELY Statements should start on a tabstop