Attention is currently required from: laforge, pespin, fixeria. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31417 ) Change subject: l1sap: Accept RFC5993 and TS 101.318 HR GSM payload ...................................................................... Patch Set 2: (3 comments) File src/common/l1sap.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3941): https://gerrit.osmocom.org/c/osmo-bts/+/31417/comment/778ba377_993bb992 PS2, Line 1267: } else else is not generally useful after a break or return Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3941): https://gerrit.osmocom.org/c/osmo-bts/+/31417/comment/eac2b05e_2c06847f PS2, Line 1267: } else suspect code indent for conditional statements (16, 20) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3941): https://gerrit.osmocom.org/c/osmo-bts/+/31417/comment/7b6e5f80_840f97e3 PS2, Line 1268: if (OSMO_UNLIKELY Statements should start on a tabstop -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31417 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I453562da412fde5b928bd2b588129c58ec8e2a7e Gerrit-Change-Number: 31417 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 23 Feb 2023 15:10:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment