Attention is currently required from: dexter.
laforge has posted comments on this change by dexter. (
https://gerrit.osmocom.org/c/pysim/+/37931?usp=email )
Change subject: scp: fix key length in dek_encrypt and dek_decrypt
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/pysim/+/37931/comment/8c4baa08_496bc272?usp=em… :
PS1, Line 9: When creating the DES cipher object with DES.new, we use the property
: card_keys.dek. This property may hold a 16 byte key, but DES uses
: an 8 byte key. Pycryptodome does not automatically ignore excess key
: bytes. Instead it throws an exception. This means we need to make sure
: to supply only the first 8 bytes of card_keys.dek
did you check the spec and determie that this truncation is required/intended? IF yes, it
would be great to add a comment with the spec reference to the code [optionally also the
commit log]. Thanks.
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/37931?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I92e0dc6a6196b532bd8b53fca7b9e78070d6903f
Gerrit-Change-Number: 37931
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 27 Aug 2024 14:20:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No