Attention is currently required from: dexter.

View Change

1 comment:

• Commit Message:

  • Patch Set #1, Line 9:

    When creating the DES cipher object with DES.new, we use the property
    card_keys.dek. This property may hold a 16 byte key, but DES uses
    an 8 byte key. Pycryptodome does not automatically ignore excess key
    bytes. Instead it throws an exception. This means we need to make sure
    to supply only the first 8 bytes of card_keys.dek
    

    did you check the spec and determie that this truncation is required/intended? IF yes, it would be great to add a comment with the spec reference to the code [optionally also the commit log]. Thanks.

To view, visit change 37931. To unsubscribe, or for help writing mail filters, visit settings.