Attention is currently required from: arehbein.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/33891
)
Change subject: osmo-bsc (WIP): Have PCU socket connection use osmo_wqueue
......................................................................
Patch Set 1:
(2 comments)
File src/osmo-bsc/pcu_sock.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/33891/comment/f76a8fce_37fb568a
PS1, Line 845: return -1;
aren't you leaking msgb here? Or is it freed by the caller?
https://gerrit.osmocom.org/c/osmo-bsc/+/33891/comment/a0621aa4_e5c84e75
PS1, Line 853: return -1;
aren't you leaking msgb here? Or is it freed by the caller?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/33891
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ifd9741045a87338e17eec3492590a5de9c308cb5
Gerrit-Change-Number: 33891
Gerrit-PatchSet: 1
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: arehbein <arehbein(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 24 Jul 2023 08:45:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment