Attention is currently required from: fixeria, pespin.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38398?usp=email )
Change subject: SGSN: BSSGP_ConnHdlr: f_gmm_attach(): allow the SGSN to request the IMEI ......................................................................
Patch Set 5:
(2 comments)
File sgsn/BSSGP_ConnHdlr.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38398/comment/10caf5b9_e6332... : PS1, Line 577: deactivate(di);
shouldn't this happen before receiving attach accept? meaning you can deactivate this after f_proces […]
Ack, could be further upwards.
File sgsn/BSSGP_ConnHdlr.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38398/comment/fc943af9_c24f9... : PS2, Line 561: f_process_attach_accept(l3_mt.msgs.gprs_mm.attachAccept, ran_index);
Acknowledged
I've refactored it.