Attention is currently required from: lynxis lazus. Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39562?usp=email ) Change subject: Rework SGSN code to use new libvlr code ...................................................................... Patch Set 4: (24 comments) File src/sgsn/gprs_gmm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21557): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/bb57cf5d_87f0af0a?us… : PS4, Line 1220: if (req.mi.type == GSM_MI_TYPE_IMSI) { braces {} are not necessary for any arm of this statement Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21557): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/a841d331_0d57ce20?us… : PS4, Line 1290: if (!mmctx->attach_rau.rau_fsm || rc != 0) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21557): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/fd022cec_f5eaf3c3?us… : PS4, Line 1551: else { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21557): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/26fbbe17_7ffe4287?us… : PS4, Line 1555: if (TLVP_PRESENT(&req.tlv, GSM48_IE_GMM_PTMSI_TYPE)) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21557): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/0fec6145_93762eeb?us… : PS4, Line 1673: if (!foreign_ra && that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21557): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/9a7ebf17_aebd7d12?us… : PS4, Line 1759: if (!strlen(mmctx->imsi) && strlen(mmctx->vsub->imsi)) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21557): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/ffc9c863_d270c054?us… : PS4, Line 1787: if (mmctx) { braces {} are not necessary for any arm of this statement Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21557): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/99d02e1b_10f1a963?us… : PS4, Line 1817: if (!mmctx->attach_rau.rau_fsm || rc != 0) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21557): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/0bb86375_e7aebba7?us… : PS4, Line 1964: } else { else is not generally useful after a break or return Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21557): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/2724ac7d_0aabe301?us… : PS4, Line 2321: if (!strlen(mmctx->imsi) && strlen(mmctx->vsub->imsi)) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21557): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/e50243e4_83a1550e?us… : PS4, Line 2345: /* FIXME: when loosing the VLR subscriber, we should ensure the GMM is in IDLE (same for PMM) */ 'loosing' may be misspelled - perhaps 'losing'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21557): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/6a4c9647_db60339a?us… : PS4, Line 2372: if (ctx->p_tmsi != send_tmsi && ctx->p_tmsi != GSM_RESERVED_TMSI && send_tmsi != GSM_RESERVED_TMSI) that open brace { should be on the previous line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21557): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/1b791a60_c0648f9d?us… : PS4, Line 2387: if (ctx->attach_rau.rau_fsm) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21557): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/649c6ca8_c53ca757?us… : PS4, Line 2393: switch(ctx->ran_type) { space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21557): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/35ae470f_7048a7e7?us… : PS4, Line 2431: if (ctx->iu.mm_state_fsm->state == ST_PMM_CONNECTED) { braces {} are not necessary for single statement blocks File src/sgsn/gprs_rau_fsm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21557): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/21358c47_cad1ca2f?us… : PS4, Line 206: switch(mmctx->ran_type) { space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21557): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/5116f786_6f238d73?us… : PS4, Line 231: switch(mmctx->ran_type) { space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21557): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/a8565d44_3b08bfc7?us… : PS4, Line 304: .in_event_mask = S(GMM_RAU_E_UE_RAU_REQUEST) | S(GMM_RAU_E_VLR_RAU_ACCEPT) | S(GMM_RAU_E_VLR_RAU_REJECT) | S(GMM_RAU_E_VLR_TERM_SUCCESS)| S(GMM_RAU_E_VLR_TERM_FAIL), need consistent spacing around '|' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21557): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/002515ec_fd8b4210?us… : PS4, Line 310: .in_event_mask = S(GMM_RAU_E_UE_RAU_COMPLETE) | S(GMM_RAU_E_VLR_RAU_REJECT) | S(GMM_RAU_E_VLR_RAU_ACCEPT) | S(GMM_RAU_E_UE_RAU_REQUEST) | S(GMM_RAU_E_VLR_TERM_SUCCESS)| S(GMM_RAU_E_VLR_TERM_FAIL), need consistent spacing around '|' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21557): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/02639ec3_4b65e310?us… : PS4, Line 339: static __attribute__((constructor)) void gmm_rau_fsm_init() Bad function definition - void gmm_rau_fsm_init() should probably be void gmm_rau_fsm_init(void) File src/sgsn/mmctx.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21557): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/3174b32b_4772c105?us… : PS4, Line 619: if (!strlen(mm->imsi) && strlen(mm->vsub->imsi)) { braces {} are not necessary for single statement blocks File src/sgsn/sgsn_libgtp.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21557): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/4d650748_31b265ee?us… : PS4, Line 537: if (cause != GTPCAUSE_NON_EXIST) { braces {} are not necessary for single statement blocks File src/sgsn/sgsn_main.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21557): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/4958ebaa_38e521d5?us… : PS4, Line 360: [DVLR] = { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21557): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/98f9e5c8_671583df?us… : PS4, Line 364: }, please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39562?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I9c5b4ec1b337c35e85c2d1a3d09b318380ae6ef8 Gerrit-Change-Number: 39562 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 17 Feb 2025 10:36:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No