Attention is currently required from: fixeria, laforge.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34697?usp=email )
Change subject: transport: do not catch exceptions in init_reader
......................................................................
Patch Set 2:
(2 comments)
File pySim/transport/__init__.py:
https://gerrit.osmocom.org/c/pysim/+/34697/comment/ed984e04_e4e4be6d
PS1, Line 295: Optional
no more `Optional`
Done
https://gerrit.osmocom.org/c/pysim/+/34697/comment/87242e54_9bd5a36a
PS1, Line 299: sl = None # type : :Optional[LinkBase]
not needed anymore
Done
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/34697?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I4c4807576fe63cf71a7d33b243a3f8fea0b7ff23
Gerrit-Change-Number: 34697
Gerrit-PatchSet: 2
Gerrit-Owner: dexter
pmaier@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Mon, 16 Oct 2023 12:36:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de
Gerrit-MessageType: comment