Attention is currently required from: msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/29752 ) Change subject: SNDCP: add LLE-specific logging wrapper ...................................................................... Patch Set 4: Code-Review-1 (1 comment) File src/sgsn/gprs_sndcp.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/29752/comment/f1686ed8_dac088c0 PS4, Line 225: (LLE)->llme->tlli, (LLE)->sapi, (NSAPI), llist_count(&gprs_sndcp_entities), ##ARGS) Counting a list every time we log something sounds a bit crazy... Do we really need that? if you want that better keep a separate counter and increment and decrement it... -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/29752 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Idfab1f4be034fc8eab8f87bd8cd88723939e107e Gerrit-Change-Number: 29752 Gerrit-PatchSet: 4 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Fri, 14 Oct 2022 12:19:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment