Attention is currently required from: pespin.

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38486?usp=email )

Change subject: vlr: Add support for CS and PS timers ......................................................................

Patch Set 2:

(1 comment)

File src/libvlr/vlr_lu_fsm.c:

https://gerrit.osmocom.org/c/osmo-msc/+/38486/comment/f81e7a86_0aa03852?usp=... : PS2, Line 449: osmo_tdef_fsm_inst_state_chg(fi, LU_COMPL_VLR_S_WAIT_TMSI_CNF, lu_compl_fsm_state_tdef, vlr_tdefs, 6);

you ar echanging the behavior here with this "6" at the end I think.

The 6 should never trigger because there is always a timer in the tdef. So what is the correct behavior? Set it to 1 to ensure it triggers in a programmer error? Set it to -1?