Change in osmo-ttcn3-hacks[master]: hnbgw: test PS RAB Ass both with and without PFCP - gerrit-log

14 Sep 2022


      Attention is currently required from: pespin.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29231 )
Change subject: hnbgw: test PS RAB Ass both with and without PFCP
......................................................................
Patch Set 4: Code-Review+2
(2 comments)
Patchset:
PS4: 
combine votes
File hnbgw/HNBGW_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29231/comment/49290e89_51818... 
PS4, Line 1447: 	if (mp_enable_pfcp_tests) {
...
You could probably have the same test name, and do one thing or another inside the test based on mp_ […]
the tests are quite different.
Without PFCP the RAB Assignment msgs should go through 1:1,
while with PFCP we make sure the GTP tunnels returned by PFCP end up in the forwarded messages. You can see that the "without" test is much shorter and has much less "infrastructure" involved.
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29231
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I511e758807e0512c18f3f9e0a8c4699b9a3f5992
Gerrit-Change-Number: 29231
Gerrit-PatchSet: 4
Gerrit-Owner: neels nhofmeyr@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel dwillmann@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: neels nhofmeyr@sysmocom.de
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Wed, 14 Sep 2022 10:42:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin pespin@sysmocom.de
Gerrit-MessageType: comment