Change in libosmocore[master]: ctrl: add optional port to bind command - gerrit-log

5 Dec 2022


      Attention is currently required from: osmith.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30444 )
Change subject: ctrl: add optional port to bind command
......................................................................
Patch Set 5:
(1 comment)
File src/ctrl/control_vty.c:
https://gerrit.osmocom.org/c/libosmocore/+/30444/comment/15a18e80_a276c483 
PS5, Line 34:       "bind A.B.C.D [<0-65535>]",
...
It looks like this only works if the application using libosmocore actually uses ctrl_vty_get_bind_p […]
That's exactly how vty_get_bind_port() works though. I think it's less confusing to keep the same (albeit somewhat ugly) semantics for both ctrl and vty binds.
-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30444
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0fd87fd41fd3ac975273968d24f477daa3cd3aa9
Gerrit-Change-Number: 30444
Gerrit-PatchSet: 5
Gerrit-Owner: msuraev msuraev@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-CC: osmith osmith@sysmocom.de
Gerrit-Attention: osmith osmith@sysmocom.de
Gerrit-Comment-Date: Mon, 05 Dec 2022 16:02:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith osmith@sysmocom.de
Gerrit-MessageType: comment