Attention is currently required from: arehbein, dexter, laforge.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33892?usp=email )

Change subject: bsc: Make socket queue max. length configurable ......................................................................

Patch Set 8: Code-Review+1

(2 comments)

File src/osmo-bsc/bsc_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/33892/comment/59475bc3_d0846a7b PS8, Line 2499: size_t to = (net->pcu_sock_wqueue_len_max = atoi(argv[0])); this new variable is really not needed and just makes everything more complex, specially with the parenthesis in there.

https://gerrit.osmocom.org/c/osmo-bsc/+/33892/comment/d00434b0_899ce34d PS8, Line 2503: LOGP(DPCU, LOGL_INFO, "Have dropped %zu messages due to shortened max. message queue size (from: %zu to %zu)\n", it may be good to do vty_out with the same message here, to show the user of the VTY what happened as a consequenc eof the cmd typed.