Attention is currently required from: arehbein, dexter, laforge.

Patch set 8:Code-Review +1

View Change

2 comments:

• File src/osmo-bsc/bsc_vty.c:

  • Patch Set #8, Line 2499: size_t to = (net->pcu_sock_wqueue_len_max = atoi(argv[0]));

    this new variable is really not needed and just makes everything more complex, specially with the parenthesis in there.

  • Patch Set #8, Line 2503: LOGP(DPCU, LOGL_INFO, "Have dropped %zu messages due to shortened max. message queue size (from: %zu to %zu)\n",

    it may be good to do vty_out with the same message here, to show the user of the VTY what happened as a consequenc eof the cmd typed.

To view, visit change 33892. To unsubscribe, or for help writing mail filters, visit settings.