Attention is currently required from: osmith, fixeria.

Hello Jenkins Builder, laforge, fixeria,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-msc/+/33591

to look at the new patch set (#3).

Change subject: csd_bs_list_to_gsm0808_channel_type: add T 300 ......................................................................

csd_bs_list_to_gsm0808_channel_type: add T 300

There is no GSM0808_DATA_RATE_TRANSP_300 (not in libosmocore and not in 3GPP TS 48.008 § 3.2.11 on which the enum is based). As I understand it, we need to use GSM0808_DATA_RATE_TRANSP_600 and half rate TCH.

As pointed out in review, either TCH/H2.4 or TCH/F2.4 would work, so use GSM0808_DATA_FULL_PREF. It was also considered using FULL_PREF for other rates below 9600, but while it is technically possible we are not setting it here as TCH/F provides so much more redundancy and hence robustness.

Use GSM0808_DATA_FULL_BM instead of GSM0808_SPEECH_FULL_BM. The value is 0x8 for both, but this is the correct name.

Related: OS#4394 Change-Id: I7297cc481fbe36355b5231ca800cf566a1ee93c0 --- M src/libmsc/csd_bs.c 1 file changed, 33 insertions(+), 4 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/91/33591/3