Attention is currently required from: fixeria, laforge.
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/pysim/+/34932?usp=email )
Change subject: runtime: refactor file selection methods select and select_file
......................................................................
Patch Set 2:
(4 comments)
File pySim/runtime.py:
https://gerrit.osmocom.org/c/pysim/+/34932/comment/965df6aa_a206d527
PS1, Line 174:
yeah, we've seen this already several times. […]
Done
https://gerrit.osmocom.org/c/pysim/+/34932/comment/b4df4396_b30556bf
PS1, Line 296: CardFile
`Optional[CardFile]`
Done
https://gerrit.osmocom.org/c/pysim/+/34932/comment/be65dd6f_2e57cdef
PS1, Line 298:
tabs vs spaces
Done
https://gerrit.osmocom.org/c/pysim/+/34932/comment/41d1b7bd_4c2be2cf
PS1, Line 375:
tabs vs spaces
Done
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/34932?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I9ae213f3b078983f3e6d4c11db38fdbe504c84f2
Gerrit-Change-Number: 34932
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 01 Nov 2023 14:53:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment