Attention is currently required from: Hoernchen, fixeria, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/36465?usp=email ) Change subject: doc: Introduce documentation for osmo-trx-ipc and its IPC interface ...................................................................... Patch Set 1: (4 comments) File doc/manuals/chapters/ipc_if.adoc: https://gerrit.osmocom.org/c/osmo-trx/+/36465/comment/ee2d1a91_f8030a4a PS1, Line 16: different Done https://gerrit.osmocom.org/c/osmo-trx/+/36465/comment/8bd181d0_63014053 PS1, Line 28: * _Channel_ UD socket: One for : each channel man Yes, but I fixed it anyway. https://gerrit.osmocom.org/c/osmo-trx/+/36465/comment/45c4b313_8d16833a PS1, Line 94: `!0` on error To me "!0" is more easily readable here, since it's not really a comparison operator, just negating it. File doc/manuals/chapters/trx-backends.adoc: https://gerrit.osmocom.org/c/osmo-trx/+/36465/comment/602bd805_a8ace44a PS1, Line 126: and also Done -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/36465?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Id6863731f9398720030b16efaaf559e05f2444ed Gerrit-Change-Number: 36465 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 26 Mar 2024 20:34:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment