Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36153?usp=email ) Change subject: Add clear error for kernel not supporting IPv6 ...................................................................... Patch Set 1: (1 comment) File ggsn/ggsn.c: https://gerrit.osmocom.org/c/osmo-ggsn/+/36153/comment/0ef3e394_325254b0 PS1, Line 537: LOGPPDP(LOGL_ERROR, pdp, "Your kernel does not support GTP-U with IPv6 yet\n"); Stating this unconditionally is a bit agressive imho, because there are other cases where EINVAL can be returned probably. I'd rephrase it to: "Cannot add tunnel to kernel: %s. Maybe your kernel doesn't support IPv6 GTP-U yet?\n" -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36153?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I1d3c8cbb51212c91136292347dad9529a5c58a31 Gerrit-Change-Number: 36153 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Mar 2024 10:10:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment