Attention is currently required from: fixeria, osmith, pespin. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/41038?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: gsm48_cc_tx_setup_set_transaction_id: split out ...................................................................... gsm48_cc_tx_setup_set_transaction_id: split out Move the code for setting the transaction ID to a separate function to start making gsm48_cc_tx_setup shorter and easier to read. Return -1 on error instead of rc from mncc_release_ind() as it returns 0 on success. Make some tweaks while at it: * Set LOGL_ERROR for the "TX Setup with assigned transaction" error. * Add a log message for the "could not get a free transaction ID" case. * Minor formatting tweaks. Change-Id: I715f12d09570211a98b667c56960309bd326e8d8 --- M src/libmsc/gsm_04_08_cc.c 1 file changed, 32 insertions(+), 23 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/38/41038/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41038?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I715f12d09570211a98b667c56960309bd326e8d8 Gerrit-Change-Number: 41038 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>