Attention is currently required from: laforge, pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/30101 )
Change subject: trxcon: reorganize the core logic into libtrxcon.la
......................................................................
Patch Set 2:
(2 comments)
File src/host/trxcon/src/trxcon_inst.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/30101/comment/ae5caeff_abbadc0d
PS2, Line 31: extern int g_logc_l1c;
you could even just store an array here and use it
internally: […]
Either way is ok with me. What you suggest, IMO, is a bit more
cumbersome though.
https://gerrit.osmocom.org/c/osmocom-bb/+/30101/comment/ec4a1507_3ef0dcab
PS2, Line 51: schc = logc[i];
so this two aren't used?
This two? Unused? I
don't understand the question, sorry.
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/30101
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Idf207947f620a7394e0a0e5bf2c37bcd8df64bbe
Gerrit-Change-Number: 30101
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 18 Nov 2022 13:31:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment